If you have a large number of sites on your bad list (or even lots of sites in your log), you would be better served with a hash. You could populate the hash with the contents of the original array and then use 'exists' for your comparison. So the above code could be written as:

use strict;
use warnings;

my @sites=qw/
              www.yahoo.com
              www.google.com
              www.comcast.com
            /;
my @bad_log;
my @good_log;

my %bad_hash = ();
foreach my $bad_site (@sites) {
  $bad_hash{$bad_site} = 1;
}

while (my $line = <DATA>) {
  my $www = (split / /,$line)[5];
  $www =~ s/---*//;
  if (exists $bad_hash{$www}) {
    push(@bad_log, $line);
  } else {
    push(@good_log, $line);
  }
}

print "\nBad lines are:\n";
foreach (@bad_log) { print; }
print "\nGood lines are:\n";
foreach (@good_log) { print; }

__DATA__
X456 TV-yes DB-no 123.12.23.45 dealio3 www.google.com-------- FX-yes d
+53 Y-03
X123 TV-yes DB-yes 34.154.43.21 dealio1 www.ask.com-------- FX-no d01 
+Y-03
X412 TV-no DB-no 192.365.25.23 rayovac2 www.microsoft.com--- FX-yes d1
+3 Y-07

[download]
which returns


Bad lines are:
X456 TV-yes DB-no 123.12.23.45 dealio3 www.google.com-------- FX-yes d
+53 Y-03

Good lines are:
X123 TV-yes DB-yes 34.154.43.21 dealio1 www.ask.com-------- FX-no d01 
+Y-03
X412 TV-no DB-no 192.365.25.23 rayovac2 www.microsoft.com--- FX-yes d1
+3 Y-07

[download]

In reply to Re: divide one file into multiple arrays by ramlight
in thread divide one file into multiple arrays by tevus_oriley

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.