Hello stamp1982,

You should provide a prompt to alert the user that input is required. For example: print "Enter a list of sequence lengths, separated by whitespace:\n";. And this line: $input .= $num . "". $num; is wrong; it should be something like $input .= $num . " ";. Also, to split on whitespace, you should use split(/\s+/, $input);. See split.

But the main problem arises from your repeated declarations of the $sum variable. my is used to declare and initialise a lexical variable (and if no initialisation is given explicitly, a scalar variable is by default initialised to undef). So the final few lines should be:

print "Total input is: $input\n";

my @nums = split(/\s+/, $input);

my $sum;
   $sum += $_ for @nums;

print $sum / @nums . "\n";

[download]

Note that $sum is here declared (and initialised) once only. Any further use of my on $sum would create a new variable with the same name, which is not what you want. See e.g. Variable scoping.

Hope that helps,

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

In reply to Re: Diagnose code by Athanasius
in thread Diagnose code by stamp1982

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.