You seem to be confused about references: 

$RESULT = &getdata(\%DATA,\%CONFIG,\%STATIC);  ##read config-file
...
if ($PROTO =~ m/ssh/i){
    %DATA = &connect2cpe_SSH(\%DATA,\%CONFIG,\%STATIC); 
}else{
    %DATA = &connect2cpe_TELNET(\%DATA,\%CONFIG,\%STATIC);
}

[download]

You are calling those functions with references to three hashes but only in getdata() do you actually dereference those hashes: 

                    $STATIC->{$T[0]}=$T[1];
...
                $DATA{$IP}->{COMMANDS} = \@COMMANDS;
                $DATA{$IP}->{MATCHES} = \@MATCHES;

[download]

Otherwise you are just modifying the file scoped hashes.

And then for connect2cpe_SSH() and connect2cpe_TELNET() you copy the already modified %DATA back to itself?    Whether you modify %DATA directly or through a reference there is no need to copy it to itself. 



if ($#ARGV < 0 ) { &help($0); exit 0;}
...
    'help|h'   => sub { &help($0); exit 0;}
     ) || die(&help($0));

[download]

help() returns a value but you never use that value so why return it?    You pass the $0 variable to help() but because you import help() into the current program the $0 variable is directly available inside help().    Every time you use help() you exit the program.    Perhaps you should put an exit at the end of the help() subroutine and maybe call it "print_help_and_exit"?

In reply to Re: RFC: beginner level script improvement by jwkrahn
in thread RFC: beginner level script improvement by georgecarlin

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.