sub sendmail {
    my ($REPORT,$CONFIG,$RESULT) = @_;
    my $T = gettime();
    my $MAIL_TO = $CONFIG{MAIL_TO}[0];
    delete $CONFIG{MAIL_TO}[0];
    my @MAIL_CC = $CONFIG{MAIL_TO};

[download]

You pass in three arguments ($REPORT, $CONFIG and $RESULT) but you never actually use these references inside this subroutine.

delete $CONFIG{MAIL_TO}[0] changes the current value of $CONFIG{MAIL_TO}[0] to undef and returns the previous value, it does not change the size of the array.    What you probably really want to do is: 

    my $MAIL_TO = shift @{ $CONFIG{ MAIL_TO } };

[download]

You assign the scalar value $CONFIG{MAIL_TO} to an array but you should just assign it to a scalar variable: 

    my $MAIL_CC = $CONFIG{ MAIL_TO };

[download]


    if ($RESULT == 1){
...
    }else{
        $CONFIG{MAIL_DATA} .= "ERROR: TACACS SERVICE VERIFICATION FAIL
+ED!\nReason:";
        if ($RESULT == 1){ $CONFIG{MAIL_DATA} .= "HUBSITE: $CONFIG{HUB
+SITE} is unreachable\n";}
        if ($RESULT == 2){ $CONFIG{MAIL_DATA} .= "Provided Username/pa
+ssword combination failed Auth
+entication\n";}
        if ($RESULT == 2){ $CONFIG{MAIL_DATA} .= "Provided Username/pa
+ssword combination passed Auth
+entication, but tacacs profile doesn't allow privileged mode\n";}

[download]

The else block of if ($RESULT == 1){ means that $RESULT is NOT equal to 1 but you still test for that.

Why do you have two tests for $RESULT == 2?

In reply to Re: RFC: beginner level script improvement by jwkrahn
in thread RFC: beginner level script improvement by georgecarlin

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.