One brief comment - Always use the 2 argument form of bless,
bless($self,$class);
so that the class can be subclassed. You may need to check the
$class, depending on how it is called, so
my $proto = shift;
my $class = ref($proto) || $proto;
# stuff to create self
bless($self,$class);
is good practice. bless returns the item as well, so you could write
your new() method as
sub new
{
my ($proto,$name,$type,$end) = @_;
my $class = ref($proto) || $proto;
return bless
{
name => $name,
type => $type,
end => $end,
attributes => {},
}, $class;
}
--
Brovnik
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.