IMHASO, (...And Sober...)

I wouldn't get worried about the fact that intersect operates on more than one Line. So does 'equals' - you just take another member of the class as an arg and its all quite natural.

As I suspect you think too, the Helpers idea is barbaric. Why use objects at all in that case?

So one OO way to do it (in pseudo-code definitions) would be:

Polygon: ->new( Point p1, Point p2, ... ); ->has_inside( Point p ); # return true/false ->get_outside_point(); # return Point outside the polygon ->first_line(); # return 'line 1' - reset counter ->next_line(); # return next_line, incr counter # undef if no more Line: ->new( Point x, Point y ); ->intersects( Line l ); # return true/false # Is this what you mean by 'same_line'? ->equals( Line l ); # return true/false

Lastly, I like to name 'private' methods with a leading underscore. So if ->same_line or ->equals is really only needed by ->intersects you might want to rename it to ->_equals.

(This is just documentation obviously. Anyone with the MilliClue (or KiloClue) who wishes to violate the published API is free to. This is perl, after all.)

However, in this particular case it seems like a sensible function to have as part of the object's "published" API and so I probably wouldn't do it.


In reply to Re: Points, Lines. Polygons OO my by jbert
in thread Points, Lines. Polygons OO my by mitd

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.