You've fallen for the basic readdir trap

Also, you're not using $^I correctly (you really don't want to use it anyway)

Make your life easier by using Path::Tiny, improve this program 

#!/usr/bin/perl --
##
##
##
## perltidy -olq  -csc -csci=3 -cscl="sub : BEGIN END if " -otr -opr -
+ce -nibc -i=4 -pt=0   "-nsak=*"
## perltidy -olq  -csc -csci=10 -cscl="sub : BEGIN END if " -otr -opr 
+-ce -nibc -i=4 -pt=0   "-nsak=*"
#!/usr/bin/perl --
use strict;
use warnings;
use Path::Tiny qw/ path /;
use POSIX();
use autodie qw/ close /;

Main( @ARGV );
exit( 0 );

sub Main {
    my $date      = POSIX::strftime( '%Y-%m-%d', localtime );
    my $bak       = "$date.bak";
    my @xml_files = path( $directory )->children( qr/\.xml$/ );
    for my $file ( @xml_files ) {
        Diddle( $file, "$file-$bak" );
    }
} ## end sub Main

sub Diddle {
    my( $in, $bak ) = @_;
    
    path( $in )->move( $bak );
    
    my $infh  = path( $bak )->openr_raw;
    my $outfh = path( $in )->openrw_raw;
    
    while( <$infh> ) {
        s{&}{&amp;}g; ## will match more than what you want fix it
        s{&amp;amp;}{&amp;}g;
        s{\s>\s}{&gt;}g;
        s{\s<\s}{&lt;}g;
        print $outfh $_;
    }
    
    close $infh;
    close $outfh;
} ## end sub Diddle

[download]

In reply to Re: search and replace strings in different files in a directory (Path::Tiny) by Anonymous Monk
in thread search and replace strings in different files in a directory by PitifulProgrammer

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.