Hello deyaneria,

The logic of the do ... while loop is wrong. If the user answers “N”, the script still asks for a PID and then attempts to kill it! Also, you shouldn’t mix system with backticks (they are two ways of doing the same thing). Try something like this (untested):

sub kill_process
{
    print "Kill processes for the user? (y or n)?\n";
    my $ans = <>;

    while ($ans =~ /^Y/i)
    {
        print "Enter pid to kill:\n";
        my $pid = <>;
        chomp $pid;

        if (is_valid($pid))
        {
            `kill $pid`;
            print "Process $pid killed\n";
        }
        else
        {
            print "Process $pid is invalid\n";
        }

        print "Kill more processes for the user? (y or n)?\n";
        my $ans = <>;
    }
}

[download]

(You will need to implement sub is_valid too.)

Hope that helps,

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

In reply to Re: Killing processes by Athanasius
in thread Killing processes by deyaneria

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.