For one, you don't need both of those patterns at the top,
if you just replace
$text =~ s/$target/$replace/;
$text =~ s/$target2/$replace/;
with
$text =~ s/$target/$replace/i; # Case-insensitive
Second, I'd look at letting Perl's -i and -p flags do all your editing
in place for you. It takes care of all the globbing, the
reading the file, etc etc etc.
For instance, your code could simply be (rough and untested):
#!perl -i~ -p
BEGIN {
$/ = undef;
$target = blah blah blah;
$replace = blah blah blah;
}
s/$target/$replace/ig;
And you'd just call it as:
myprog.pl *.asp
Perl has some very powerful, very common idioms to
do this most common of text transformations. Take
advantage of them when you can.
xoxo,
Andy
--
<megaphone>
Throw down the gun and tiara and come out of the float!
</megaphone>
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.