comment on

First of all, please provide something runnable in your future questions instead of forcing us to do that work.

use strict;
use warnings qw( all );

my @binimage = ( "\x00", "\x00", "\x00", "\x00", "\x00", "\x90" );
my $nextrow = 5;
my $col = 0;
my $subcol = 0;

for my $index (0..5) {
    my $thisrow = $nextrow - $index;
    print "processing row/column/bit $thisrow/$col/$subcol: " . substr
+($binimage[$thisrow], $col, 1) . "\n";

    printf ("Incoming byte is %d/%x/%8b/%s.  Test bitmask is %d/%x/%8b
+/%s.\n",
        substr($binimage[$thisrow], $col, 1),
        substr($binimage[$thisrow], $col, 1),
        substr($binimage[$thisrow], $col, 1),
        unpack('B8',substr($binimage[$thisrow], $col, 1)),
        2**(7-$subcol),
        2**(7-$subcol),
        2**(7-$subcol),
        unpack('B8', 2**(7-$subcol)));

    printf "%s\n", ((substr($binimage[$thisrow], $col, 1)) & 2**(7-$su
+bcol))? "1" : "0";
}
[download]

Secondly, ALWAYS USE use strict; use warnings qw( all );!!! This is the output of the above program:

printf (...) interpreted as function at a.pl line 13.
processing row/column/bit 5/0/0: &#9618;
Argument "M-^P" isn't numeric in printf at a.pl line 13.
Argument "M-^P" isn't numeric in printf at a.pl line 13.
Argument "M-^P" isn't numeric in printf at a.pl line 13.
Incoming byte is 0/0/       0/10010000.  Test bitmask is 128/80/100000
+00/00110001.
Argument "M-^P" isn't numeric in bitwise and (&) at a.pl line 23.
0
processing row/column/bit 4/0/0:
Argument "\0" isn't numeric in printf at a.pl line 13.
Argument "\0" isn't numeric in printf at a.pl line 13.
Argument "\0" isn't numeric in printf at a.pl line 13.
Incoming byte is 0/0/       0/00000000.  Test bitmask is 128/80/100000
+00/00110001.
Argument "\0" isn't numeric in bitwise and (&) at a.pl line 23.
0
processing row/column/bit 3/0/0:
Argument "\0" isn't numeric in printf at a.pl line 13.
Argument "\0" isn't numeric in printf at a.pl line 13.
Argument "\0" isn't numeric in printf at a.pl line 13.
Incoming byte is 0/0/       0/00000000.  Test bitmask is 128/80/100000
+00/00110001.
Argument "\0" isn't numeric in bitwise and (&) at a.pl line 23.
0
processing row/column/bit 2/0/0:
Argument "\0" isn't numeric in printf at a.pl line 13.
Argument "\0" isn't numeric in printf at a.pl line 13.
Argument "\0" isn't numeric in printf at a.pl line 13.
Incoming byte is 0/0/       0/00000000.  Test bitmask is 128/80/100000
+00/00110001.
Argument "\0" isn't numeric in bitwise and (&) at a.pl line 23.
0
processing row/column/bit 1/0/0:
Argument "\0" isn't numeric in printf at a.pl line 13.
Argument "\0" isn't numeric in printf at a.pl line 13.
Argument "\0" isn't numeric in printf at a.pl line 13.
Incoming byte is 0/0/       0/00000000.  Test bitmask is 128/80/100000
+00/00110001.
Argument "\0" isn't numeric in bitwise and (&) at a.pl line 23.
0
processing row/column/bit 0/0/0:
Argument "\0" isn't numeric in printf at a.pl line 13.
Argument "\0" isn't numeric in printf at a.pl line 13.
Argument "\0" isn't numeric in printf at a.pl line 13.
Incoming byte is 0/0/       0/00000000.  Test bitmask is 128/80/100000
+00/00110001.
Argument "\0" isn't numeric in bitwise and (&) at a.pl line 23.
0
[download]

You are repeatedly using the string resulting from "\x90" as a number, but it's not.

You are repeatedly using the string resulting from "\x00" as a number, but it's not.

Basically, everywhere you have

substr($binimage[$thisrow], $col, 1)
[download]

you should have

ord(substr($binimage[$thisrow], $col, 1))
[download]

(Inside unpack 'B8' is the exception. That one does expect a string.)

In reply to Re: I've muddled my bit and byte formats. by ikegami
in thread I've muddled my bit and byte formats. by murrayn

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.