With your code, what happens if i send a query string like foo.cgi?foo=bar&foo=baz&foo=qux?sub param { my ($self,$param) = @_; return $self->{'r'}->param($param); }
Style issues:
Remember that => automagically quotes the left hand side:
Also note that i used the direct notation to instantiate the CGI object, this is not at all necessary, but it is a good habit to get into.my $self = { r => CGI->new(), html => undef, redir => undef, };
In output(), since you are refering to $self->{r} multiple times, i recommend assigning it to a scalar:
sub output { my $self = shift; if ($self->{'redir'}) { my $r = $self->{'r'}; $r->status(302); # etc ... } }
Other than that it looks good - try mortis's suggestion, then test it with a query string that contains multilples values for one variable. Make sure you get an array back, otherwise you might want to just write a wrapper for the param method like i did. But, again, what is the purpose of this module, why would i want to use it instead of CGI.pm?
jeffa
L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
F--F--F--F--F--F--F--F--
(the triplet paradiddle)
In reply to (jeffa) Re: CGI Buffer module will not return params.
by jeffa
in thread CGI Buffer module will not return params.
by IOrdy
| For: | Use: | ||
| & | & | ||
| < | < | ||
| > | > | ||
| [ | [ | ||
| ] | ] |