You may want to apply a better scaling factor to some of these categories. At this point, it seems to me that a script which:
- uses strict
- uses -T and correctly performs taint checking
- uses CGI.pm to handle CGI form input
can score
worse than a script which does
none of these, but which:
- uses CGI.pm for HTML output
- uses here-docs instead of multiple print statements
- has "good" style and "effective" commenting (by some subjective standard)
Let's keep our priorities clear. Style may count for something, but I think that security and correctness should count for much more.
Update: The security issues appear to be addressed somewhat in the previous node (which beat me by bare seconds), but I think I still have a point here somewhere...
Update2: By the way, do you need and/or want help reviewing the scripts?
buckaduck
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.