for (@_) { @differences = (@differences, (($_-$mean)*($_-$mean))); } To my eye,
foreach ( @_ ) { push @differences, $_ - $mean; }
reads better.

In the fragment

my $standard = 0; for (@differences) { $standard = $standard + $_; } $standard = sqrt($standard/$sample_size); return $standard;
you use $standard for two semantically different (though related) purposes. Having variables that mean two (or more) different things within a subroutine can get you into trouble later (say, when you pick up the code a couple of months from now). You can eliminate this problem by writing
my $sum_diff = 0; map { $sum_diff += $_ } @differences; return sqrt($sum_diff / $sample_size);

You might also consider using 4 spaces for indentation.

And at some point, somebody is going to pass an empty list...


In reply to Re: Code Review! Go Ahead, Rip It Up! by dws
in thread Code Review! Go Ahead, Rip It Up! by chaoticset

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.