I'd like to suggest formatting more like this for your code.

Code formatting is a religious topic, so let me just walk around the topic gingerly by suggesting that you want to make the code as readable as possible so that it's easy to maintain, easy to document, and easy to debug. Never assume that once you write a piece of code you're never going to have to deal with it again. Unless it's a one-liner, you're probably going to have to go back to it. 

sub ProcessFile { 
  my $data=''; 
  my $datalength=0; 
  my $startchar=''; 
  open (RAWFILE, "$processfilename") || die "cannot open: $!"; 
  open (CLEANFILE, ">$cleanfilename") || die "cannot open: $!"; 
  while (<RAWFILE>){ 
    $rawfilelength++; 
    $data = $_; 
    $datalength = length($data); 
    $startchar = ord($data); 
    if ($startchar == $correctstartchar){ 
      if($datalength == $correctstartlength){ 
        chomp $data; 
        chop $data; 
        $data = reverse ($data); 
        chop $data; 
        $data = reverse ($data); 
      }else{ 
        next; 
      } 
      if (length($data) == $correctcleanlength){ 
        print CLEANFILE "$data\n"; 
        $cleanfilelength++; 
      } 
    }elsif ($datalength == $typedlength){ 
      print CLEANFILE "$data"; 
      $cleanfilelength++; 
    }elsif ($datalength > $correctcleanlength) { 
      my $datalengthtrack = $datalength; 
      chomp $data; 
      $datalengthtrack--; 
      chop $data; 
      $datalengthtrack--; 
      $data = reverse ($data); 
      while ($datalengthtrack > $correctcleanlength){ 
        chop $data; 
        $datalengthtrack--; 
      } 
      $data = reverse ($data); 
      print CLEANFILE "$data\n"; 
      $cleanfilelength++; 
    }elsif ($datalength < $correctcleanlength) { 
      next; 
    } 


  } 
  close (RAWFILE) || die "cannot close $processfilename: $!"; 
  close (CLEANFILE) || die "cannot close $cleanfilename: $!"; 
} 
print "\a"; 
exit(0);

[download]

--t. alex

"Of course, you realize that this means war." -- Bugs Bunny.

In reply to Re: New Perl User Question by talexb
in thread New Perl User Question by Rpick

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.