A couple of (uncalled for ;--) comments on your script:
- if a system function (open) fails you have to die, just using || "error" will not help,
- $! is the error description, it is usally a good idea to display it when a system function fails,
- to test existence is usally done using a hash.
A couple of style points:
- if you want to open a file for reading (regfile), why not say so in the open: open( FH, "<file") instead of using >>, BTW usually filehandles are in CAPS,
- you can use undef as a placeholder in split,
- there is no need to escape . and | in strings,
- instead of reading a whole file in an array and then processing each line why not read each line, process it and then go to the next one? This way you don't have to slurp the whole file in memory.
So your code modified:
#!/bin/perl -w
use strict;
open (REGFILE, "<$datadir/projects.dat") || die "Cannot open File1: $!
+";
open (NEWFILE,">>$datadir/subscribe\.dat") || die "Cannot open File2:
+$!";
my %seen_email; # hash email => 1
while( <REGFILE>) {
my( $email, $name, $format);
($email, $name, $format, undef) = split /\|/;
next if( $seen_email{$email});
print NEWFILE"$email|$name|$format\n";
$seen_email{$email}=1; # either just the email or the whole li
+ne
}
close (NEWFILE);
close REGFILE;
An other option, if you are on any kind of unix (or cygwin) is to preprocess the initial file using sort -u:
#!/bin/perl -w
use strict;
# the die is actually useless here
open (REGFILE, "sort -u $datadir/projects.dat |") || die "Cannot open
+File1: $!";
open (NEWFILE,">>$datadir/subscribe\.dat") || die "Cannot open File2:
+$!";
while( <REGFILE>) {
my( $email, $name, $format);
($email, $name, $format, undef) = split /\|/;
print NEWFILE"$email|$name|$format\n";
}
close (NEWFILE);
close( REGFILE) || die "could not sort $datadir/projects.dat: $!"; # i
+n this case the error happens when you close the file
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.