Very good, very consitent design. But if people are going to be using this for web apps something like this might be needed
sub oracle_escape {
my $self = shift;
my ($ret_value) = @{{@_}}{qw/dirty/};
$ret_value =~ s/\'/\'\'/g;
return $ret_value;
}
and it looks like your presumes autocommit turned on. This is not normally the case, so in that case why not add these
sub commit {
my $self = shift;
$self->{'dbh'}->commit();
}
sub rollback {
my $self = shift;
$self->{'dbh'}->rollback();
}
Just some food for thought. Please tell me if you put these in, would be cool to know I helped with something on CPAN ;).
Tradez
"Never underestimate the predicability of stupidity"
- Bullet Tooth Tony, Snatch (2001)
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.