Peace be upon the Monksters;

I have a simple (or so I thought) class ('FileHash') that ties a hash to a file, reading data into the hash upon instantiation, and writing the hash out to the file when DESTROYed.

I want to use the class for several hashes e.g. 

my (%pwds, %boxes); 
tie (%pwds,  'FileHash', "$dir/pwds"); 
tie (%boxes, 'FileHash', "$dir/boxes");

[download]
but the second call to tie clears out any data that may have been read into the first hash and replaces it with the data from the second hash.

I just can't get my head around why this happens.

Here is the code for my class: 

package FileHash;
use strict;
use warnings;
use Tie::Hash;
use Data::Dumper;
our @ISA = ("Tie::Hash");

sub TIEHASH {
   my ($class, $file) = @_;
   my $s = {}; 
   $s->{DATA} = _read($file) || {};
   $s->{FILE} = $file;
   bless $s, $class;
}

sub STORE    { $_[0]->{DATA}{$_[1]} = $_[2] }
sub CLEAR    { $_[0]->{DATA} = () }
sub FETCH    { $_[0]->{DATA}{$_[1]} }
sub FIRSTKEY { my $a = scalar keys %{$_[0]}; each %{$_[0]->{DATA}} }
sub NEXTKEY  { each %{$_[0]->{DATA}} }
sub EXISTS   { exists $_[0]->{DATA}{$_[1]} }
sub DELETE   { delete $_[0]->{DATA}{$_[1]} }
sub DESTROY  { _write ($_[0]) }

# ----- private subs -----
sub _write { # still need to deal with race conditions
   my %data = %{$_[0]->{DATA}};
   my $file =   $_[0]->{FILE} ;
   open (FH, "> $file") or die "Can't open $file for FileHash _write: 
+$!";
   print FH Data::Dumper->Dump([\%data], ['*data']); 
   close FH or die "Can't close $file for FileHash _write: $!";
}

sub _read { # still need to deal with race conditions
   no strict;
   my $file = shift;
   return undef unless -f $file;
   unless (my $ret = do $file) {
      warn "couldn't parse $file: $@" if $@;
      warn "couldn't do $file: $!"    unless defined $ret;
   }
   return \%data;
}

1;

[download]

In reply to Tie-ing hashes clobbers data by Dave05

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.