This is the right idea, but your system() call isn't quite correct. When you run something like: 
system("$useradd -c \"$fullname\" ...");

[download]
then system() runs the command by way of the a shell. The shell splits the command string up into words--removing the quotes in the process--and ends up passing the '-c' and the $fullname to useradd as two separate arguments.

However, when you call: 

system( 
    $useradd, 
    qq|-c "fullname"|,
    ...

[download]
then the shell doesn't get involved, and useradd receives the exact argument list you passed to system(). In this case you've constructed a single string 
    -c "value-of-$fullname"

[download]
which useradd will percieve as a single argument, quotes and all. This probably isn't what useradd is expecting.

If you're going to use the list form of system, you really have to pass each argument as a separate list element, eg: 

system ($useradd,
    '-c', $fullname,
    '-d', "/home/sites/site$site_count/users/$username",
    '-g', "site$site_count",
    '-G', "site-adm$site_count",
    '-p', $password,
    '-s', '/bin/false',
    '-u', $uid, $username);

[download]
This way, the shell isn't involved, because you're using the list form of system(). But useradd receives each command-line argument as a separate element (with no extraneous quotes) just like it expects.

If you have trouble understanding the difference, then try running each of the following: 

system('cat -n /etc/group');
system('cat', '-n /etc/group');
system('cat', '-n', '/etc/group');

[download]
Use the q{} or qq{} quote form if you like; it shouldn't matter. The first and third lines should work; the second should give you an error of some sort.

In reply to Re: Re: Re: Re: Using doublequotes in a system call by kjherron
in thread Using doublequotes in a system call by rguyer

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.