I haven't read "The Pragmatic Programmer", but that sounds like a heck of a good idea.

That being said, bear in mind that not everyone holds themselves to the same high ideal that you apparently hold yourself. And not everyone has to. Until you become a supervisor or technical lead, you are only responsible for your won work, and that is the best place to focus your energies. I recognize the code you are trashing there, not by having seen that exact code, but by having seen very similar code at my present employer.

The fact is, we have some great programmers, very talented people who would dearly love to go back and re-work some of the code that they wrote when first learning perl. I'd love to have the luxury of going back and re-doing a lot of my code. Hwever, reality dictates that since "the old code works", we focus on what is before us today,and if we have some spare cycles at some point, we go back and clean up some of that old stuff. Or when the requirements change and we have a chance to get back in there, we clean it up.

Pick your battles too. I'd say that version control should be the first thing you attack. You can probably enlist the aid of the sysadmins in getting CVS installed on a development server, unless the sysadmins are in on the crappy code conspiracy too. They usually love the idea of not having to restore things from back up if they don't have to. Failing that, install it in a private bin directory and just start using it yourself.

As to guns-a-blazing, I would never even consider it. Not my style at all. I just try to write the best code I know how, influence not force, and flow over and around the rocks, wearing them down rather than trying to move them. Now after a year on my job, I'm getting promoted and being made technical lead on my team.


In reply to Re: OT: Job Advice by Anonymous Monk
in thread OT: Job Advice by abaxaba

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.