I believe this code is much more complex than what it needs to be.

What happens if you turn off the non-greediness in:

        if ( /(.*?)$old_hostname(.*?)/i ) 
          { 
            s/(.*?)$old_hostname(.*?)/$1$new_hostname$2/sgi;
          }
by saying something like

        if ( /(.*)$old_hostname(.*)/i ) 
          { 
            s/(.*)$old_hostname(.*)/$1$new_hostname$2/sgi;
          }
In this way it will match your prior regexp.

Also, it would have been helpful if you wrote what the output is in the first run of your code.

Also, according to those who know a lot about regexes, saying .* is actually bad as this regexp is very expensive. When you have the time, take a look around the fine Tutorials we have on the monastery. This helped me a lot with the regexes.

Good luck.

In reply to Re: Renames files and directories but won't update files at the same time. by fokat
in thread Renames files and directories but won't update files at the same time. by kirk123

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.