I agree with
grantm, you should
always use absolute paths in scripts that need to run as a cron job. From what I gather (man crontab), the script is probably invoked from your home directory. A workaround might be to use
FindBin to locate the directory the script is in.
In addition: your code isn't very Perlish. I'll try to Perlify it a bit, mainly by using grep(). Plus, you're only looking for files, not directories, are you? The test can be simplified, that way.
#!/usr/bin/perl -w
use FindBin;
chdir("$FindBin::Bin/..");
opendir(DIR, '.');
@dir = readdir(DIR);
closedir(DIR);
if(my @new = grep {-f and $_ ne "index.html"} @dir) {
# send mail...
# ...
print "New files:\n";
print " * $_\n" foreach @new;
}
I used chdir() because otherwise the filetest won't work.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.