The way I'd write this is thus:
#!/usr/bin/perl -w use strict; use Net::SSH qw(ssh); use constant USER => 'root'; use constant CMD => '/usr/local/scripts/temp.sh'; for my $host (qw( 192.168.15.2 192.168.16.2 192.168.17.2 192.168.18.2 )) { (ssh(USER . '@' . $host, CMD) != 256) and last; warn "No response from $host\n"; }
Of note is that your original code had == '256' comparisons, mixing a numerical operator with a string operand. Why? Either use == 256 (numerically compare against a number) or eq '256' (string comparison against a string). As you really mean the number 256 here, the former is the right choice, even though what you had works too. It does incur a pointless string-to-number conversion, but that's beside the point: you need to be aware of the difference because one day it will bite you if you treat them as interchangeable.

Makeshifts last the longest.


In reply to Re: Not Using So Many 'if' Statements by Aristotle
in thread Not Using So Many 'if' Statements by Dru

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.