Nice one...

Here's a test case for you; it lets you crosscheck your sub against localtime for localtime's range. 

#!/usr/bin/perl -w

use strict;

sub day_of_week {

    my ($year, $month, $day) = @_;

    my @offset  = (0, 3, 2, 5, 0, 3, 5, 1, 4, 6, 2, 4);
    $year      -= $month < 3;

    return ($year + int($year/4) - int($year/100) + int($year/400)
                  + $offset[$month-1] + $day) % 7;
}


my $i=0;
for(my $time=1; $time<2**31; $time+=86400) {
    my ($mday,$mon,$year,$wday)=(localtime($time))[3..6];
    $mon++;
    $year+=1900;

    my $day=day_of_week($year,$mon,$mday);

    # progress info...
    print ((scalar localtime($time))," $day, $wday\n") unless ($i++%10
+00);

    if($day != $wday) {
        print "Mismatch between sub ($day) and localtime ($wday) for "
+,
               (scalar localtime($time)),"\n";
    }
}

[download]
Obviously needs a bit of work to be recast as a test case, sorry.

Your routine passes on my system :)
--
Mike

In reply to Re: Day of the week by RMGir
in thread Day of the week by jmcnamara

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.