Hate to flog a dead horse (not that your code is a dead
horse - i just like that expression), but this:
$tmp[0] > $tmp[1]
? push @expanded, reverse ($tmp[1]..$tmp[0])
: push @expanded, ($tmp[0]..$tmp[1]);
is bad style because the ternery operator is being used
in void context. You would be better using an if-else
statement, because it is more readable. If you prefer the
brevity of the ternery operator, then please use it as an
assignment operator:
push @expanded, $tmp[0] > $tmp[1]
? reverse ($tmp[1]..$tmp[0])
: ($tmp[0]..$tmp[1])
;
I like the changes, by the way. Now we have a fully flogged
dead horse. :D
jeffa
L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.