oh wise monks! may a feeble noob ask for wisdom!
I have some very inefficent code, it takes way to long to run and i just know there is a better way to do it! but my skills are lacking! I have 2 files that share a string. I want to match a string from file A in File B and add a new string from File A to end of the line in File B where the common string was matched. I know this is bad but thats why asked for help!
#!/usr/bin/perl -w chomp($phi = `ls slk`); chomp($phi2 = `ls *.csv`); open(OUT,"> /home/Aug18.csv") or die "Cannot open output file; open(READDATA, "< /home/$phi") or die "Cannot Open file; my $stuff; my %h = (); while ($stuff = <READDATA>) { if ($stuff =~ /(\d\d\d\d\w\d?)\s+(\w*)/){ $port = $1; $lsn = $2; $h{$port} = $lsn; } } close READDATA; open(READDATA2, "< /home/$phi2") or die "Cannot Open file.; my $stuff2; while ($stuff2 = <READDATA2>){ while (($port2, $lsn2) = each %h){ if ($stuff2 =~/$port2/){ chomp($stuff2); print OUT "$stuff2,$lsn2\n"} } }

It works for now but my god its slow! Thanks for any advice!

In reply to 2 files 1 output by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.