As others have suggested better regexes Iam not going to ponder over what is a better regex. Read the following rule , and then browse through the code that you and others have posted.

You should always check for the success of a regex match before capturing the value in $1..$n

If the regex match fails you will end up having undefined value or some junk in $1. Always check for the success before you assign the captured values.

Your code should look like 

    if ( $zipfile  =~ m/[AB]FILE_(\d+)/ ) { 
       $day = $1;
    }
    else {
       # oops.. the file name is not what we expected ..
       # panic !!
    }

[download]

Hope this helps

-T

In reply to Re: A better regex by thens
in thread A better regex by williamp

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.