First off, a little more than ...will not work unless... would be useful.

Does this mean that the script

  1. Fails to compile?
  2. Compiles but dies with runtime errors?
  3. Runs and then traps?
  4. Runs to completion, but gives the wrong output?

The probable cause of failure is that you are sharing @source between the threads but you aren't using lock() to serialise the access.

I know you've been working on this for some time, but I don't think that using threads and shelling is likely to speed things up much. The overhead of shelling the sub-scripts will probably outweight any saving you might make by overlapping IO requests.

IN your earlier post you said that it was still slower than "doing it manually"...What does this mean? How manually? And what order of difference are you trying to make up?

I think I see a few things in your script that might be slowing things down, and I also think that you could use threads to improve things somewhat, but I don't have a network with which to test the ideas. An indication of what level of improvement you are seeking woudl make it easier for me to decide if they are worth pursuing.

Examine what is said, not who speaks.
"Efficiency is intelligent laziness." -David Dunham
"When I'm working on a problem, I never think about beauty. I think only how to solve the problem. But when I have finished, if the solution is not beautiful, I know it is wrong." -Richard Buckminster Fuller
If I understand your problem, I can solve it! Of course, the same can be said for you.

In reply to Re: Threads problem. by BrowserUk
in thread Threads problem. by blackadder

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.