also use strict and warnings.. part of your code would break under strict... no serious problems.. but in future larger projects it could make a world of difference.

I started perl doing CGI, and to look back on my horrible code from my early CGI days now would make me sick. Also something to try coding style wise is use of $_ in foreach loops, it saves a little memory and is kinda slick.

one of your loops could be re-written as...

foreach(@val)
{
  chomp;
  print "<option value=".$_.">".$_."\n";
}
[download]

Make no mistake... none of this will improve/change the funcionality, but I know from personal experience that when working with CGI and new to perl that people are often more concerned with the ends than the means...so this is just some food for thought.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.