I think the biggest thing I would have approached differently (other than using a CPAN module to do date work) is to divide the problem into parts and have code to perform each part.
# input:
chomp(my $date = <>);
# parse, return numeric year,month,day or empty list on error
if (my ($y,$m,$d) = split_date($date)) {
# print out in Month dd yy format
print "Date is: ", format_date($y,$m,$d), "\n";
} else {
print "invalid date: $date; please try again\n";
}
It doesn't make as much sense to have part of your conversion done in the main code and part done in a subroutine. Ditto for printing an error message in the main code or the successful formatting in a sub.
Update: make comment agree with code re: order of returned values; said parsing but meant conversion
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.