First of all, you can often get the database itself not to accept any duplicate numbers, if you define that table with a unique index over the number. That will work much better than doing it on your side, particularly when the table gets big.
Now to your code.
- When you're looking for a number like that, you don't need to use $&, simply enclose what you're looking for in ().
- You don't need $', because Perl will keep track of where it was in the string.
- You don't need to scan continously over an array to see if a number is there, that's what hashes are for.
- You don't need the GOTO, because Perl provides the next keyword.
I left your variable names as they were, so that you will find it easier to compare your code to mine. But in general, all caps for a variable name is rare in Perl. Oh, and contends should probably be contents...
while ($CONTENDS=~/(\d{10})/g) {
$match=$1;
$IDNUMBER{$match}=1 unless $IDNUMBER{$match};
}
foreach $match (keys %IDNUMBER) {
$sqlinsert="INSERT INTO $tab[$loop] VALUES('$match')";
$rc=$db->Sql($sqlinsert);
die qq(SQL fail "$rc":), $db->Error(),qq(n) if $rc;
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.