I created the hash manually to associate the file name with the file - if there's another/better way to do that I'd be very interested to know.

If you must hardwire the filenames, I don't have anything against using a hash to store them. I just might not have bothered with the intermediate scalar variables:

my $data2="/home/users/some_path/edit/data2.txt"; my $data1 ="/home/users/some_path/edit/data1.txt"; my $data3 ="/home/users/some_path/edit/data3.txt"; my %dbs = ( Data1 => $data1, Data2 => $data2, Data3 => $data3, );

...could be written more legibly as:

my %dbs = ( Data2 => "/home/users/some_path/edit/data2.txt", Data1 => "/home/users/some_path/edit/data1.txt", Data3 => "/home/users/some_path/edit/data3.txt", );

But that's, as I mentioned, just a style issue. I may be out of style myself. ;)


Dave


In reply to Re: Re: Re: Increase efficiency of script by davido
in thread Increase efficiency of script by jonnyfolk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.