What you're doing inside your createUserFile is grabbing the "user" parameter from your CGI script without checking it. Meanwhile, you're running your script with taint checking on (the -T option). Since you're not doing any kind of checking on the input that you get from the CGI script, the input is considered tainted by default.

To untaint the user input, do as ccn suggested:

param('user') =~ /^(\w+)$/
  or die "Bad parameter " . param('user');

my $theFile = "$1.txt";

[download]

This will prevent the user from entering some potentially destructive input that will execute an "rm -r /" command on your system.

-Yendor

IWeThey
HOPE Ride

In reply to Re: Insecure dependency in open by Yendor
in thread Insecure dependency in open by pskiz

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.