Here's another iterator solution that avoids the recursion altogether. There are three differences:
- It will return undef instead of an empty array ref if the number of items is less than the amount to choose (ie 3 choose 5).
- The amount to choose is passed before the list of items instead of afterwards because I thought it was weird, although your way does make sense if one thinks of it like "Here are 50 things, choose 5".
- The output order is a bit different.
All three of these can certainly be fixed, but I wanted to keep the code clear.
sub choose_n_iter {
my @todo = [ shift, [ @_ ], [] ];
return sub {
while ( @todo ) {
my ( $n, $pool, $tally ) = @{ shift @todo };
return $tally if $n == 0;
next if @$pool == 0;
my ( $first, @rest ) = @$pool;
push @todo, [ $n - 1, \@rest, [ @$tally, $first ]],
[ $n , \@rest, $tally ];
}
return;
};
}
And here is a more effecient version:
sub choose_n_iter {
my @todo = [ shift, [ @_ ], [] ];
return sub {
while ( @todo ) {
my ( $n, $pool, $tally ) = @{ shift @todo };
return $tally if $n == 0;
return [ @$tally, @$pool ] if $n == @$pool;
next if @$pool == 0;
my ( $first, @rest ) = @$pool;
push @todo, [ $n - 1, \@rest, [ @$tally, $first ]];
push @todo, [ $n , \@rest, $tally ] if @res
+t;
}
return;
};
}
Thanks goes out to
HOP for the recursion-to-iterator help.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.