I am using a couple of subroutines in a basic script to parse a text file:

#!/usr/bin/perl -w
use strict;
my $text, $ques, $ans;

open(IN, "<$ARGV[0]")||die"Couldn't open $ARGV[0]: $!\n";
while(<IN>){
  $text = &do_one_thing($_);
  ($ques, $ans) = &do_another_thing($text);
  print $ques." :: ".$ans."\n";
}
close(IN);

sub $do_one_thing{
  my $line=uc($_);
  $line =~ s/this/that/g;
  return($line);
}

sub $do_another_thing{
  my $another_line, $one, $two;
  $another_line = $_;
  ($one, $two) = $another_line =~ /(.[^\*]*)\*(.*)/;
  return($one, $two);
}

[download]


So my question is, why do $ques and $ans remain lowercase; more generally, why does the second subroutine again use $_ from the main body of the program, rather than the local $_ (which I'm guessing ought to be $text)? I can rearrange the script pretty simply to make it work (by not using the extra variable) which I did, but it made me curious as to why it doesn't work the way I've written it above...

thanks!

In reply to Why is this incorrect? by kettle

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.