With the help of the Perl Monk expertise, I've been able to finish a project I started back in February. In a nutshell, it changes the perms on a series of several hundred files in different directories, does a pattern search for two lines separated by text that is discarded, puts the two lines in a hash, then searches the files, one at a time in a loop, for a match to the Key. When a match is found, the Value is linked, using s///.

I am fairly confident that it works; however, everytime I try to test, it runs for several hours, then I get an error messge "Exceeded CPU Limit". I get no error messages from the Perl code, the CPU error is from the system.

I know I have asked alot, but if someone could look at what I've done and see if there is a more efficient way to do any part of the project, I would appreciate it. It takes hours just to change the permissions on the files, and I don't know why.

use strict;
use warnings;
use diagnostics;
use File::Copy;
use FileHandle;
use IO::File;
#---------------------------------------------------------------------
+-

# Variables, Arrays and Hash declarations:

my ($manualdir_param) = @ARGV;
my $working_dir = $manualdir_param;
$working_dir =~ s/manualdir=//i;
my $data_area = "/tmp";
my $html_dir = "$data_area/$working_dir";
my @FigureArray;
my @endingArray;
my $FigFile;
my @FileArray;
my @endArray;
my $DirFile;
my %images;
my $line;
my $img;
my $fig;

#---------------------------------------------------------------------
+-

# Loop to locate HTML files, change permissions, and make working temp
+orary copies

opendir( HTMLSTORIES, "$html_dir") || die "HTML dirs do not exist: $1"
+;
        @FigureArray = grep{/^(09)(\w{1,5})(00)$/} readdir ( HTMLSTORI
+ES );

                foreach $FigFile (@FigureArray)
 {

                        opendir( HTMSTORY, "$html_dir/$FigFile" ) || d
+ie "Files do not exist: $1";
                        @FileArray = grep{/a.htm$/} readdir ( HTMSTORY
+ );

                foreach $DirFile (@FileArray)
                        {
                        #       copy ("$html_dir/$FigFile/$DirFile", "
+$html_dir/$FigFile/$DirFile.bak") or die "Can not make backup copy of
+ file: $1";
                                chmod 0600, "$html_dir/$FigFile/$DirFi
+le";


                foreach $DirFile (@FileArray)
                        {

 open (PATTERN, "<", "$html_dir/$FigFile/$DirFile") or die "Unable to 
+open pattern file: $1";
 
                        while (<PATTERN>)
                        {
                        chomp;
 
                        if ($line = /(\<IMG\sSRC\=.*?\>)/.../(Figure\s
+*\d+)/)
                        {
                                $img = $1;
                                $fig = $3;
                        }
 
                        if ($img && $fig)       # if we find both IMG 
+AND Figure lines, add them to images hash.
                        {
                                $images{$fig} = $img;
                        }
 
                        foreach (sort keys %images)
                        {
                                # print "$_: $images{$_}\n";
                        }
 
# find matching Figure lines in text file and do linking.
 
                        while (( $fig, $img) = each(%images))
                        {
 
                                grep{$fig} "$html_dir/$FigFile/$DirFil
+e";
                                        s/$fig/"<a href = $img>$fig<\/
+a>"/g;

                        %images = ();
                        }
                        }

close (PATTERN);
closedir HTMSTORY;
closedir HTMLSTORIES;

# Loop to do cleanup

opendir( ENDSTORIES, "$html_dir") || die "HTML dirs do not exist: $1";
        @endingArray = grep{/^(09)(\w{1,5})(00)$/} readdir ( ENDSTORIE
+S );

foreach $FigFile (@endingArray)
{

        opendir( ENDSTORY, "$html_dir/$FigFile" ) || die "Files do not
+ exist: $1";
                @endArray = grep{/a.htm.bak$/} readdir ( ENDSTORY );

                foreach $DirFile (@endArray)
                {
                                # unlink ("$html_dir/$FigFile/$DirFile
+.bak") or die "Can not remove backup copy of
file: $1";
                                chmod 0644, "$html_dir/$FigFile/$DirFi
+le";
                }
                        }
close ENDSTORY;
close PATTERN;
closedir HTMSTORY;
closedir HTMLSTORIES;
                        }
}
}

[download]

READMORE tags added by Arunbear

In reply to Exceeding CPU Limit by xdbd063

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.