Your x!! approach is nifty, but it's a little hard to read: the double-negation is confusing unless explained, and the x operator seems to be out of place in this context. I have always found one of these easier to read:
my $uri;
foreach (
'http://example.net/app',
$is_admin_link && 'admin',
$subsite,
$mode,
$id,
$submode,
) {
$uri.="$_/" if ( defined $_ && length($_) ) #omit undef and empties
}
If you need to preserve the parts seperately:
my @part = (
'http://example.net/app',
$is_admin_link && 'admin',
$subsite,
$mode,
$id,
$submode,
);
my $uri;
foreach (@parts) {
$uri.="$_/" if ( defined $_ && length($_) ) #omit undef and empties
}
I prefer these because:
- The logic for inclusion of parts is clear
- It makes it easy to apply a common rule to all components (e.g. URL-ify components before concatenation)
- It avoids repetition of code
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.