A line in my code says: 
open (TagPrint::THELOG, ">&STDOUT") or die "dup: $!";

[download]
and this works WONDERFUL. I have no problems with it. It has been running for many months. Now the boss wants to have all the code in the respoitory scanned with Perl::Critic, which I generally accept as a "good thing" (use proper Martha Stewart voice here).

The problem is that the line barfs for a couple of reasons:

1) A bareword file handle and

2) Two argument open.

My question: What is the 'fix'? From the stuff I read, if I want to duplicate a file handle, I should use the two argument form. Also, what do I quote to get around the 'bareword' complaint. The idea was to keep the file handle inside the module (TagPrint) since it is very localized.

Suggestions??

In reply to On being 'critical' by herby1620

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.