1. use strict; !
  2. There is no need for the @array variable, you can assign to a list of variables directly: 
    @array=split(/-/,$value);
$pdbid=$array[0];
$from=$array[1];
$to=$array[2];
$chainid=$array[3];
if($chainid eq "_")
{
$chainid=" ";
}
$menu1=$array[4];
$menu2=$array[5];
$menu3=$array[6];
@array=();

    [download]
    is better written as 
    ($pdbid, $from, $to, $chainid, $menu1, $menu2, $menu3) = split(/-/,$va
+lue);
if($chainid eq "_") {
  $chainid=" ";
}

    [download]
  3. You should find better names for the $menu1, $menu2 and $menu3 variables.
  4. The rows of print statements are hard to read and completely unnecessary. Use qq{} or heredocs: 
            print <<"*END*";
select :$chainid
wireframe on
wireframe 70
select :$chainid
spacefill on
select :$chainid
spacefill 0.55
select $from-$to:$chainid
wireframe on
wireframe 70
select $from-$to:$chainid
spacefill on
select $from-$to:$chainid
spacefill 0.55
select $from-$to:$chainid
color green
*END*

    [download]

Jenda
Support Denmark!
Defend the free world!

In reply to Re: Regarding Perl+Rasmol Script by Jenda
in thread Regarding Perl+Rasmol Script by editi

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.