Bugs:
- = is the assignment operator, not a comparison operator. Use == to compare numbers. Use eq to compare strings.
Improvements that can be made:
- Paragraph mode could be used here. Check out $/.
- There's no need to read in the whole file into memory.
- Using 3-arg open when possible is safer. (open(..., '<...') → open(..., '<', '...'))
- open is rather likely to fail. Check to make sure it succeeds.
- Using lexicals when possible is safer. (FILE → $fh)
- Uppercase variable names are usually reserved for constants.
Resulting code:
my $file_name = ...;
my $kwd = ...;
open my $fh, '<', $file_name
or die("Unable to open file \"$file_name\": $!\n");
local $/ = "";
while (<$fh>) {
chomp;
my @fields = split /:/, $_;
if ($fields[1] eq $kwd) {
print "$_\n\n";
}
}
Update: You asked about writting it to another file:
my $fn_in = ...;
my $fn_out = ...;
my $kwd = ...;
open my $fh_in, '<', $fn_in
or die("Unable to open file \"$fn_in\": $!\n");
open my $fh_out, '>', $fn_out
or die("Unable to create file \"$fn_out\": $!\n");
local $/ = "";
while (<$fh_in>) {
chomp;
my @fields = split /:/, $_;
if ($fields[1] eq $kwd) {
print $fh_out "$_\n\n";
}
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.