If at all possible I would try to go through the combinations of items once at the beginning of the script, taking the process out of the while ( <$fh> ) { ... } loop, building a single regex to match any wanted line. Something like

my @items = ();
foreach my $subset ( keys %lookingFor )
{
    foreach my $item ( @$subset )
    {
        push @items, $item;
    }
}
my $rxMatchItems;
{
    local $" = q{|};
    $rxMatchItems = qr{(?:@items)};
}

[download]

As others have pointed out, open the output file once at the beginning of the script then the remainder of the code could be reduced to something like

while ( <$fh> )
{
    next unless m{$rxMatchItems};
    print $writeFh $_;
}

[download]

This approach all depends on whether your items can easily be combined into one regex, but I think it might be more efficient if feasible.

I hope this is of use.

Cheers,

JohnGG

In reply to Re: how to parse large files by johngg
in thread how to parse large files by domcyrus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.