Hi.

Have you checked the results of your code for Fisher's Exact Test? I don't think it produces correct results.

Here's a utility that produces results identical to those I calculate: http://www.exactoid.com/fisher/index.php

This expression at the beginning of your code seems odd: 

$test = $a*($a+$b+$c+$d ) - ($a+$b)*($a+$c);

[download]
It simplifies to: $test = $a*$d - $b*$c;

I don't follow why you have this: 

return 1 if $test < 0 and $ts;

[download]
For example, if a = 1, b = 50, c = 10 and d = 5, P(one-sided) = P(two-sided) = 1.4386e-07, not 1.

Nevertheless, thanks for the tip about calculating factorials only once. Let me know if I've misunderstood something.

In reply to Re: Fisher's Exact Test by resonator
in thread Fisher's Exact Test by tlm

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.