Module code should localize any special variables it uses in each location it uses them. This is a smart and sane practice. Watch:
package MyConfigReader;
sub readConfig {
my ($file,$var) = @_;
open FILE, "< $file" or die "can't read $file: $!";
while (<FILE>) {
chomp;
my ($k,$v) = split /=/, $_, 2;
return $v if $k eq $var;
}
close FILE;
return;
}
That looks innocent, right? Watch it get blown to hell:
use MyConfigReader;
$/ = "not gonna happen";
MyConfigReader::readConfig("whatever.dat");
My program has just modified the
input record separator variable. The module relied on that being
\n, and now it isn't.
sub readConfig {
my ($file,$var) = @_;
local ($_, $/);
$/ = "\n";
# rest of function
}
So yes, this is something you should be doing. Trusting the user is potentially silly. Perhaps there should be a switch like
-T that catches blind use of "true globals" like you demonstrated.
japhy --
Perl and Regex Hacker
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.