The key to overcoming fear of re-factoring (which is a reasonable fear to have) is having a good unit test suite that you're confident in. One of the code bases I work on is pretty poorly factored, and the unit test suite is not much better. There have been one or two times where I've made what seemed like perfectly reasonable and logical refactors, only to find I'd introduced a bug elsewhere in the app. I'm now extremely cautious of the code base, and will take a very conservative approach to any change I'm making.

At some stage (since it's possible large scale changes may need to be made to this app), I plan to re-write the test suite from scratch. At the same time, I'll hopefully be allowed to refactor the code base.

I certainly wouldn't want to refactor without that safety net of the test suite. Once a code base reaches a certain level of complexity, it's impossible to keep every edge case, scenario, possibility, etc. in your head. That's why we have computers to take care of those things for us.

In reply to Re: On the fear of re-factoring code by Mutant
in thread On the fear of re-factoring code by deorth

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.