OK, hard to say whats going wrong when you don't include forkit. Anyway, lets see if we can find some improvements. The only thing I can really make out is smallest. No need to use ls, as it might confuse your forkIt(if you use wait). Try this instead: 
smallest{
 my ($dir,$arr_ref)=@_;
 my %sc; #Cache of file sizes;
 return +(sort {$sc{$a}||=-s $a;
                       $sc{$b}||=-s $b;
                       $sc{$a} <=> $sc{$b}
                       } map { "$dir/$_" } @$arr_ref)[0];
}

[download]
That should be efficent enough.

As for the rest, I don't understand what you try to do. You have one main loop. The first thing you do, is to shift a file off  @dbFilePaths. That means it will only go through that loop once for all those filepaths. Inside the loop is one big if/elsif block. So, for each of those FilePath's, one of those blocks will be executed, and finally you fork of, presumably to execute the command you set in the if/elsif block

Furthemore, since you never set @copiedFiles or @verifiedFiles, 2 of those blocks will never get executed. I think you should try to post a version that you feel is somewhat correct, or failing that, put in some comments on what you think is going on in the code

GoldClaw

In reply to Re: fork and reap by goldclaw
in thread fork and reap by gennari

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.