I see a different problem with dopen

my $x = dopen( 'file-not-found' );
__END__
Can't open `file-not-found': No such file or directory
readline() on closed filehandle $fh
[download]

Ouch. How about this instead:

my $x = dopen( '/dev/null', 'file-not-found', '/etc/passwd' );

sub dopen {
    my @t = map {
        my $fh;
        open $fh, '<', $_ and <$fh> or warn "Can't open `$_': $!\n";
    } @_;
    \@t;
}
__END__
Can't open `/dev/null':
Can't open `file-not-found': No such file or directory
[download]

That has a different problem. It reports an error just because the file happens to be empty.

How about this, then:

my $x = dopen( '/dev/null', 'file-not-found', '/etc/passwd' );

sub dopen {
    my $out = [];
  FILE:
    foreach my $file ( @_ ) {
        my $fh;
        if ( ! open $fh, '<', $file ) {
            warn "Can't read '$file': $!\n";
            next FILE;
        }
        push @{$out}, <$fh>;
    }
    return $out;
}
__END__
Can't read 'file-not-found': No such file or directory
[download]

Looks good! It's readable, it complains at the right times, and it doesn't die when I meant it to warn.

I know this does not answer the question you asked. You seem to be looking for a way to do "sub dopen { [ map { open my $f, '<', $_ or warn "Can't open `$_': $!\n"; <$f> } @_ ] }" without the oh-so-confusing [] hanging around at the outskirts. My point is, that's the least of your problems. Write it so it works and so that someone can understand it.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.