You should, as good practice, use strict; and use warnings;, along with explicit initializing variables - it's obviously not necessary but can save headaches. There are a number of so-called best practices you aren't following, but they are less essential (4-space indent, clear names for variables, ...). Is there a reason you hold off on parsing your @temp array 'till you've read in an entire block? From what I read, it seems like you could do the same thing with:

use strict; use warnings; my $transaction_flag = 0; my $match_flag = 0; my $count = 0; my @value_list = ('154216722'); my @transaction = (); while (my $line = <>) { if ($line =~ /\<BEGIN Transaction\>/){ $transaction_flag = 1; } if ($transaction_flag) { push @transaction, $line; for (@value_list) { if ($line =~ /$_/) { $match_flag = 1; $count++; } } } if ($line =~ /\<\/END Transaction\>/){ $transaction_flag = 0; if ($match_flag) { print @transaction; } $match_flag = 0; @transaction = (); } }
This also compares against an entire list of match values at once, which is likely desirable if you want to test against 5000 numbers.

In reply to Re: Match a list of numbers from a list of files by kennethk
in thread Match a list of numbers from a list of files by shawshankred

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.