<counteropinion>

Unless performance is a concern, go with what's most readable.

For a lone string test, use lc() and eq. But if you've already used a couple of regex's to test $foo, it may be more readable to throw in another one, rather than switching gears and using lc() and string compare.

Consider adding a test below this fragment: 

  next if $foo =~ /^#/;
  if ( $foo =~ /^(?:this|that|or|something|else)$/ { ... }

[download]
Now which reads better   if ( $foo =~ /^$bar$/i ) { ... } or   if ( lc($foo) eq lc($bar) ) { ... } I'll argue that it's at best a toss-up. As a reader of fragments like this, I see the pattern of a variable being tested against a sequence of regex's, and my brian goes into regex scanning mode. Mixing in a string comparision might be technically correct, but it breaks up the reading flow, at least in examples like this.

</counteropinion>

In reply to (dws)Re: Regexes Are Not For String Comparison by dws
in thread Regexes Are Not For String Comparison by japhy

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.