As others have noted, ? is the character for place holders in DBI. I recommend reading about them and using them, they make life much better and a far more efficient, especially if you use $dbi->prepare_cached, which won't recompile your sql statement every time.

You should change your function to look like this: 

sub Do_SQL {
  my $dbh = shift; # unless you are using a bad global
  my $statement = shift;
  my @values = shift;

  # don't check for errors here as chances are
  # no runtime errors will occur once you are done
  # debuging your code
  my $sth = $dbh->prepare_cached($statement);

  # interopolates your placeholders
  $sth->execute(@values)
    or error_function($dbh->errstr); # you can do 
                                     # the print here
 
}

So, with this you could do database work with: 

Do_SQL(
  $dbh, 
  'INSERT INTO some_tbl (some_text) VALUES(?)',
  'Hello?'
);

Keep in mind that this is very limiting; you can't check the return values of your statements to find out the number of rows affected and so forth. cheers.

In reply to Re: question mark? by DrZaius
in thread question mark? by Monolith-0

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.