You correctly pass an array reference to the function  find_broken_links, but then within the function you stringize the reference
    my $broken_links = ( defined $_[1] ) ? "$_[1]" : return ;
before assigning it to a variable. This renders the reference useless as a reference.

The solution: don't do that:
    my $broken_links = ( defined $_[1] ) ? $_[1] : return ;

In addition, my own personal preference is to separate argument assignment and validation within a function rather than trying to bury them both in a single statement. I feel it leads to more readable and maintainable code. 

sub find_broken_links {

    my ($location,
        $broken_links,
        ) = @_;

    return unless defined($location) and defined($broken_links);

    ... do stuff ...

    push @$broken_links, 'stuff';

    return;

    }

[download]
Update: BTW, kudos for using strictures and (I hope) warnings.

In reply to Re: Modifying Arrays passed by reference to subroutine by AnomalousMonk
in thread Modifying Arrays passed by reference to subroutine by sadarax

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.