To reiterate chromatic, you should generally "declare" your my variables as late as possible so that they are scoped in the appropriate BLOCKs.

Let's take $sig for example. When you declared

my ($r, $rad, $twopi, $sig, $pi, $a0, $c0);
[download]

what you're saying is $sig is available for the rest of the entire program (file-scoped). That works, but it's good practice to only scope $sig where it is used.

Hence, remove my (..., $sig, ...); above and rewrite your if-statement like:

    if ($r>20)
        {
        my $sig = $twopi*($rad**2);
        push (@sigs, $sig);
        }
    else
        {
        my $sig = $pi*($rad**2)*$a0*(1-exp((-$c0)*$rad));
        push (@sigs, $sig);
        }
[download]

Now $sig is lexically scoped to either of those two BLOCKs. Try using $sig outside those blocks and you'll trigger a warning. This is a good thing.

Why? This approach leads to cleaner code in the long run:

• Less confusion, easier debugging.
• It allows you to structure your thoughts better when variables are "compartmentalized".
• Plus, it's way easier to declare when-you-need-it rather than maintaining a huge list at the very beginning of the program.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.